fix(Teleport): component with multi roots should be removed when unmounted #3157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3156
When removing the
Teleport
during patching, we cannot use the internal renderer methodremove
because there may be components in Teleport’s children, so we need to useunmount
instead.BTW: The reason why a component with a single root can be removed is because the
vnode.el
of the component is the root DOM node of the component, which is not the case for components with multiple roots.