Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR select option value hydration does not reify types correctly #4006

Closed
tjk opened this issue Jun 26, 2021 · 0 comments
Closed

SSR select option value hydration does not reify types correctly #4006

tjk opened this issue Jun 26, 2021 · 0 comments
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: ssr

Comments

@tjk
Copy link
Contributor

tjk commented Jun 26, 2021

Version

3.1.2

Reproduction link

https://github.com/tjk/vue-ssr-hydrate-select-options-bug

Steps to reproduce

See README in repro repo

What is expected?

Types to be correct

What is actually happening?

Emitted types are strings
@edison1105 edison1105 mentioned this issue Jun 26, 2021
Closed
@posva posva added 🐞 bug Something isn't working ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: ssr labels Jun 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: ssr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(hydration): should patch option's value when hydrate select edison1105/vuejs-core
2 participants
@tjk @posva