fix(build): build vue-compat in default exports mode #4460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f2fb8a5 introduced change in rollup configuration -
output.exports
for all packages was swapped fromauto
tonamed
(to avoid warnings, I assume). Unfortunately this brokevue-compat
commonJS package where single default export is expected to be spreaded so@vue/compat
will be a drop-in replacement forvue
.Now, for example, when you require
@vue/compat
in node.js environment (for example when running vue-test-utils) you need to accessdefineComponent
asrequire('@vue/compat').default.defineComponent
instead ofrequire('@vue/compat').defineComponent
Since
@vue/compat
is expected to serve as "drop-in" replacement forvue
this PR is forcingoutput.expots = default
forvue-compat
package which is exactly the expected case - rollup expects single default export