fix(compiler-core): dedupe renderSlot's default props #4557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fix the duplicated default props in
renderSlot
code generation and simplifies the logic by splicing a default argument array.Minimal reproduction
renderSlot
takes at most 5 arguments but the compiler generates 6.Note the last argument
true
should follow immediately after the fallback function.It looks like an accidental bug that default
slotProps
is pushed twice when children are defined and SFC has no slotted selector.Instead we can provide a default arg array, set arguments in their position if defined, and finally splice the array to remove unused args.