fix(server-renderer): respect compilerOptions during runtime template compilation #4631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the deprecated form of
isCustomElement
is respected when performing runtime template compilation with SSR. All other compiler options are ignored. e.g.:This PR attempts to use
compilerOptions
consistently with other forms of template compilation.Unresolved problems:
The cache does not take the options into consideration. It was already ignoringNow fixed.isCustomElement
and I didn't want to expand the scope of this PR.runtime-core/src/component.ts
. Extracting the logic to a shared function should be a fairly painless refactor.isCustomElement
anddelimiters
do not show warnings during SSR.