Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): return hook() in wrappedHook to handle the async call in KeepAliveHook. #4978

Merged
merged 3 commits into from
Nov 22, 2021
Merged

fix(runtime-core): return hook() in wrappedHook to handle the async call in KeepAliveHook. #4978

merged 3 commits into from
Nov 22, 2021

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Nov 20, 2021

fix #4976

LinusBorg
LinusBorg requested changes Nov 20, 2021
View reviewed changes
Copy link
Member

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a separate test for this instead of repurposing the existing one? KeepAlive.spec would be a good place for this since we are testing the correct behaviour of the wrapped KeepAlive hooks.

packages/runtime-core/__tests__/errorHandling.spec.ts Outdated Show resolved Hide resolved
@ygj6 ygj6 requested a review from LinusBorg November 22, 2021 02:57
@yyx990803 yyx990803 merged commit 820a143 into vuejs:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

errorHandler doesn't catch errors from onActivated when callback is async
3 participants
@ygj6 @LinusBorg @yyx990803