Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): transition hooks can be arrays of functions #5177

Merged
merged 2 commits into from
May 11, 2022

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Dec 28, 2021

Passing an array of functions to transition hooks currently triggers

TS2322: Type '(() => void)[]' is not assignable to type '(el: Element) => void'.

or onLeave is not a function at runtime with the onEnter/onLeave/onAppear hooks.

@KaelWD KaelWD changed the title fix(transition): transition hooks can be arrays of functions fix(runtime-core): transition hooks can be arrays of functions Dec 28, 2021
@KaelWD KaelWD marked this pull request as ready for review December 28, 2021 12:42
@netlify
Copy link

netlify bot commented Mar 16, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 47cd33a
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/627b155818fc3f000855fa65
😎 Deploy Preview https://deploy-preview-5177--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 16, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 47cd33a
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/627b1558c7629c000880207f
😎 Deploy Preview https://deploy-preview-5177--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 16, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 47cd33a
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/627b155818fc3f000855fa63
😎 Deploy Preview https://deploy-preview-5177--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@LinusBorg LinusBorg added scope: transition 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Mar 18, 2022
@yyx990803 yyx990803 merged commit fec12d7 into vuejs:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants