Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shared): parse multi-line inline style #6777

Merged
merged 3 commits into from
Nov 8, 2022
Merged

fix(shared): parse multi-line inline style #6777

merged 3 commits into from
Nov 8, 2022

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Sep 29, 2022 •
edited
Loading

@sxzz sxzz changed the title fix(shared): multi line style fix(shared): parse multi line style Sep 29, 2022
@sxzz sxzz changed the title fix(shared): parse multi line style fix(shared): parse multi-line inline style Sep 29, 2022
songjianet
songjianet approved these changes Sep 29, 2022
View reviewed changes
Copy link

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antfu
antfu approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a test case to avoid future regression?

@sxzz

This comment was marked as resolved.

Sign in to view
@antfu antfu added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Oct 3, 2022
@netlify
Copy link

netlify bot commented Nov 8, 2022

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 2a50d03
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6369c988fc93b8000df0339a

@yyx990803 yyx990803 merged commit 9768949 into vuejs:main Nov 8, 2022
@sxzz sxzz deleted the fix/multi-line-style branch November 8, 2022 08:30
@mnixry mnixry mentioned this pull request Dec 28, 2022
Closed
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@sxzz
fix(shared): fix parsing of multi-line inline style (vuejs#6777)
3d68a95
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
@sxzz @zhangzhonghe
fix(shared): fix parsing of multi-line inline style (vuejs#6777)
b5e5f8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 left review comments

@songjianet songjianet songjianet approved these changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sxzz @yyx990803 @antfu @songjianet