Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-model): fix the lazy modifier is not reset by other modifications #8547

Merged
merged 7 commits into from
May 31, 2024

Conversation

Alfred-Skyblue
Copy link
Member

@Alfred-Skyblue Alfred-Skyblue commented Jun 12, 2023

fixed #8546
fixed #6564

We should not block the update if the currently bound value is updated, In this PR, the value of the current element will only be reset if the value of the v-model bound to the current element is modified, since I can't simulate the focus event in jsdom, I can't write a test case for it.

@Alfred-Skyblue Alfred-Skyblue changed the title fix(v-model): fix lazy modifier not syncing external changes fix(v-model): fix the lazy modifier is not reset by other modifications Jun 12, 2023
@Alfred-Skyblue Alfred-Skyblue marked this pull request as ready for review June 12, 2023 04:17
@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jun 12, 2023

📝 Ran ecosystem CI: Open

suite result
nuxt ✅ success
pinia ✅ success
quasar ❌ failure
router ❌ failure
test-utils ❌ failure
vant ✅ success
vite-plugin-vue ✅ success
vitepress ❌ failure
vue-macros ❌ failure
vuetify ✅ success
vueuse ✅ success
vue-simple-compiler ✅ success

@Alfred-Skyblue
Copy link
Member Author

The error of ecoystem-ci confuses me, it seems to have nothing to do with this PR.

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87.1 kB (+18 B) 33.1 kB (+4 B) 29.9 kB (+17 B)
vue.global.prod.js 133 kB (+18 B) 50 kB (+4 B) 44.8 kB (+39 B)

Usages

Name Size Gzip Brotli
createApp 48.4 kB 19 kB 17.4 kB
createSSRApp 51.6 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.8 kB 18.1 kB
overall 61.7 kB 23.9 kB 21.7 kB

Copy link

codspeed-hq bot commented Dec 20, 2023

CodSpeed Performance Report

Merging #8547 will not alter performance

Comparing Alfred-Skyblue:fix-vModel (f30990c) with main (9fa8241)

Summary

✅ 53 untouched benchmarks

@yyx990803 yyx990803 merged commit a52a02f into vuejs:main May 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants