Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: cancel MutationObserver listener when disconnected #8666

Merged
merged 3 commits into from
Jul 12, 2023
Merged

perf: cancel MutationObserver listener when disconnected #8666

merged 3 commits into from
Jul 12, 2023

Conversation

Alfred-Skyblue
Copy link
Member

We should disconnect MutationObserver in disconnectedCallback and set it to null for better garbage collection.

sxzz
sxzz approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Jun 28, 2023
@yyx990803 yyx990803 merged commit 24d98f0 into vuejs:main Jul 12, 2023
@Alfred-Skyblue Alfred-Skyblue deleted the perf-defineCustomElement branch July 13, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alfred-Skyblue @sxzz @yyx990803