Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unref returns wrong type #8857

Closed
Eternal-Rise opened this issue Jul 27, 2023 · 3 comments · Fixed by #8748
Closed

unref returns wrong type #8857

Eternal-Rise opened this issue Jul 27, 2023 · 3 comments · Fixed by #8748
Labels
has PR A pull request has already been submitted to solve the issue

Comments

@Eternal-Rise
Copy link

Eternal-Rise commented Jul 27, 2023 •
edited
Loading

Vue version

3

Link to minimal reproduction

https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgVwHZQKYDMA0cYQBqAhgDbIZwC+cWUEIcARAG4VMBQoks+AnmEpIAwgzDIYGACYAlbHjlZqteo1bsA3B20YAHj3gwBlRQHkoo8BOkAeACoA+OAF44i+04A+cS+MmzsDy09A35BOABZYj4AIwwzCzFrKQ8XODs4bwTfZI9tI3CAMQgINKjY+OxzHP8bJGApAC44VGQQOKhqB20AYwhUAGd4LFQ0gAowYihiEGbiiABKFycEDjh1uD7B+GmAdwAFKZm0tEwsCaOQBe0NuGAlMb3D6ZAAOgal1dvbgHofuDWGyoHGBvX6Q1oqAATONJi85iUls4VoD1lsIU9LmkCCRyBgLi9rqi7g9MS93lJPsTfv9icCqEA

Steps to reproduce

See tsplayground

What is expected?

I expect to get unrefed type

What is actually happening?

returned type of unref is still includes ComputedRef. Same for toValue

System Info

No response

Any additional comments?

No response
@laurens94
Copy link

Idem when using toValue

@censujiang
Copy link

same question

@Eternal-Rise
Copy link
Author

I believe, it will be fixed with #8748

@sxzz sxzz mentioned this issue Aug 8, 2023
Merged
@sxzz sxzz added the has PR A pull request has already been submitted to solve the issue label Aug 12, 2023
yyx990803 pushed a commit that referenced this issue Nov 10, 2023
@Alfred-Skyblue
fix(types): fix unref and toValue when input union type contains …
176d476 
…ComputedRef (#8748)

close #8747
close #8857
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has PR A pull request has already been submitted to solve the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update unref and toValue parameter type Alfred-Skyblue/vue-core
4 participants
@laurens94 @sxzz @censujiang @Eternal-Rise