Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width and height attrs problem #9762

Closed
zdm opened this issue Dec 6, 2023 · 6 comments
Closed

Width and height attrs problem #9762

zdm opened this issue Dec 6, 2023 · 6 comments
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working

Comments

@zdm
Copy link

zdm commented Dec 6, 2023

Vue version

3.3.10

Link to minimal reproduction

See below

Steps to reproduce

I am using cunstom web components ( extjs web components ) inside vue sfc template:

<teplmate>
    <ext-dialog width="100" height="100" >
</teplmate>

Width and height are passed as null.

Im vue v3.3.9 works without errors.

What is expected?

See above

What is actually happening?

See above

System Info

See above

Any additional comments?

See above

@zdm
Copy link
Author

zdm commented Dec 6, 2023

Also I am using this settings in my webpack config

{
                                "loader": "vue-loader",
                                "options": {

                                    "compilerOptions": {
                                        "isCustomElement": tag => tag.startsWith( "ext-" ),
                                    },
                                },
                            },
                            {`

@zdm
Copy link
Author

zdm commented Dec 6, 2023

I think it is related to this update: #8781

@zh-lx
Copy link
Contributor

zh-lx commented Dec 7, 2023

I think it is related to this update: #8781

This update only has an impact on emmed tag such as <img /><video /><canvas />,it won't affect custom element. For a custom element, browser doesn't support set width and height by <ext-dialog width="100" height="100" >, instead, you should set width and height by <ext-dialog style="width: 100px; height: 100px;" >

@zh-lx
Copy link
Contributor

zh-lx commented Dec 7, 2023

I find the problem, it caused by this commit: 9845f1d.

@edison1105 edison1105 added 🐞 bug Something isn't working 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Dec 7, 2023
@yyx990803
Copy link
Member

I find the problem, it caused by this commit: 9845f1d.

No, this condition was already fixed in 6fcec3b

@zdm
Copy link
Author

zdm commented Dec 7, 2023

Yhank you very much.
When we can experct for the patch release?

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants