Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incorrect feature flag name in migration build doc. #9875

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

Masa-Shin
Copy link
Contributor

The migration guide currently lists COMPILER_FILTERS as a feature flag but to disable compiler support for filters, you must specify COMPILER_FILTER: false (not plural COMPILER_FILTERS) in compatConfig. Although the enum key for the feature is COMPILER_FILTERS (plural), the value string is singular so it would be more helpful to list the singular form.

@yyx990803
Copy link
Member

Hmm, I think it's better to correct the enum value to match the key and the docs (the missing S was a mistake)

@Masa-Shin
Copy link
Contributor Author

Masa-Shin commented Dec 25, 2023

I think it's better to correct the enum value to match the key and the docs

I think that would be more ideal. I will fix it by the weekend.

@Masa-Shin Masa-Shin marked this pull request as draft December 26, 2023 01:26
@Masa-Shin Masa-Shin marked this pull request as ready for review December 29, 2023 03:52
@Masa-Shin
Copy link
Contributor Author

Updated the PR to fix enum value.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.3 kB 34 kB 30.6 kB
vue.global.prod.js 146 kB 53.2 kB 47.6 kB

Usages

Name Size Gzip Brotli
createApp 49.7 kB 19.5 kB 17.8 kB
createSSRApp 53 kB 20.8 kB 19 kB
defineCustomElement 52 kB 20.2 kB 18.4 kB
overall 63.2 kB 24.4 kB 22.2 kB

@yyx990803 yyx990803 merged commit 77d33e2 into vuejs:main Dec 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants