fix(build): add module condition in package exports

[yyx990803]

/cc @danielroe #9977 has caused a number of regressions with different causes: #10012, #10020, also got another private report from @lehni in his project.

It seems I merged it to soon and it was indeed risky in a patch. For now I have reverted the exports conditions in 7bd4e90 to avoid other unknown regressions.

This PR fixes #10012, but I need further confirmation for the other two cases. @Mister-Hope / @lehni would appreciate if you can try this commit in your project to see if it fixes your issue.

I am also not sure if the addition of module would intefere with the bundle size gain in Nitro / Nuxt.

[lehni]

@yyx990803 apologies for not creating the issue for this yet, it's still on my TODO list. Do you still need the issue now? I will test ASAP and report back in a bit.

[lehni]

@yyx990803 I finally found time to do the test, and I can confirm that this works in my case!

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	89.7 kB	34.2 kB	30.8 kB
vue.global.prod.js	147 kB	53.4 kB	47.7 kB

Usages

Name	Size	Gzip	Brotli
createApp	50.1 kB	19.6 kB	17.9 kB
createSSRApp	53.4 kB	20.9 kB	19.1 kB
defineCustomElement	52.4 kB	20.4 kB	18.6 kB
overall	63.8 kB	24.7 kB	22.4 kB

[yyx990803]

/ecosystem-ci run

[vue-bot]

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
language-tools	❌ failure	❌ failure
nuxt	✅ success	✅ success
pinia	✅ success	✅ success
quasar	✅ success	✅ success
router	✅ success	✅ success
test-utils	✅ success	✅ success
vant	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
vitepress	✅ success	✅ success
vue-i18n	✅ success	✅ success
vue-macros	✅ success	✅ success
vuetify	✅ success	✅ success
vueuse	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success

[lehni]

Just to confirm: This works in the new release. Thanks @yyx990803 !

[Mister-Hope]

Sorry for delay, the fix does not work for me @yyx990803

I am postgraduate student and busy with my thesis these days.

See https://github.com/vuepress-theme-hope/vuepress-theme-hope/actions/runs/7513512110/job/20455377640#step:7:177

The commit bump vue from 3.4.8 to 3.4.13, with nothing else. I am still meeting:

"Module not found: Error: Can't resolve 'velocityjs' in '/home/runner/work/vuepress-theme-hope/vuepress-theme-hope/node_modules/.pnpm/@[email protected]/node_modules/@vue/compiler-sfc/dist'",

Module not found: Error: Can't resolve 'dustjs-linkedin' in '/home/runner/work/vuepress-theme-hope/vuepress-theme-hope/node_modules/.pnpm/@[email protected]/node_modules/@vue/compiler-sfc/dist'

[Threebow]

Having same issue as above (#10020 where it cannot resolve velocityjs). I don't use velocityjs in any of my code. I am on the latest version of vue/compiler-sfc. Not sure if I should make another issue, as #10020 is closed however seems to be not yet fixed as noted above.