Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace deprecated SpyInstance with MockInstance #9889

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Alfred-Skyblue
Copy link
Member

@Alfred-Skyblue Alfred-Skyblue commented Dec 21, 2023

The SpyInstance type has been deprecated in vitest and is now marked as obsolete. According to the documentation, should replace it with MockInstance.

https://github.com/vitest-dev/vitest/blob/039814bd0eb9ed7b7f6e649a1c3def38d5174a5d/packages/spy/src/index.ts#L107-L110

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87.1 kB 33.1 kB 29.9 kB
vue.global.prod.js 133 kB 50 kB 44.8 kB

Usages

Name Size Gzip Brotli
createApp 48.4 kB 19 kB 17.4 kB
createSSRApp 51.6 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.8 kB 18.1 kB
overall 61.7 kB 23.9 kB 21.7 kB

Copy link

codspeed-hq bot commented Dec 21, 2023

CodSpeed Performance Report

Merging #9889 will not alter performance

Comparing Alfred-Skyblue:chore/vitest/type-deprecated (a0db20c) with main (9fa8241)

Summary

✅ 53 untouched benchmarks

@sxzz sxzz changed the title chore(vitest): replace deprecated SpyInstance import with the latest MockInstance test: replace deprecated SpyInstance with MockInstance Dec 22, 2023
@yyx990803 yyx990803 merged commit 1b522ca into vuejs:main Dec 22, 2023
13 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the chore/vitest/type-deprecated branch December 23, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants