feat!: don't split tsconfig.dom.json into two files #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found it not very useful to split the dom config into two files. - Even `@vue/compiler-dom` and `@vue/runtime-dom` are not split into different packages. They have made the `-core` versions their dependencies. - The DOM-specific options are too generic. They are not specific to Vue, but to the browser environment. If separated from the base config, I'm afraid it doesn't deserve the `@vue/` scope. It's more useful when it automatically includes the Vue base config. On the other hand, this change makes the migration from earlier versions more complicated. I'm sorry for the inconvenience brought to the early adopters. But reverting it now is better than later. Luckily, I haven't incorporated this change into `create-vue` yet. According to the npm download stats, the downloads of v0.2.0 is about 1% of v0.1.3. I hope I'm reverting it early enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it not very useful to split the dom config into two files.
@vue/compiler-domand@vue/runtime-domare not split into different packages. They have made the-coreversions their dependencies.@vue/scope. It's more useful when it automatically includes the Vue base config.On the other hand, this change makes the migration from earlier versions more complicated.
I'm sorry for the inconvenience brought to the early adopters. But reverting it now is better than later.
Luckily, I haven't incorporated this change into
create-vueyet. According to the npm download stats, the downloads of v0.2.0 is about 1% of v0.1.3. I hope I'm reverting it early enough.