fix(theme): don't let navbar obstruct clicks to top part of scrollbar #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On desktop screen sizes, if the sidebar has a scrollbar, the very top part of the scrollbar can't be clicked on because the navbar obstructs it due to having a higher z-index. (This higher z-index is necessary so that the navbar is visible.) With this fix, the navbar container has `pointer-events: none;` so that clicks to the scrollbar underneath will work. Child elements of the navbar that need to receive clicks have `pointer-events: all;` turned on for them. fix vueuse/vueuse#2086
7 tasks
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On desktop screen sizes, if the sidebar has a scrollbar, the very top
part of the scrollbar can't be clicked on because the navbar obstructs
it due to having a higher z-index. (This higher z-index is necessary so
that the navbar is visible.) With this fix, the navbar container has
pointer-events: none;so that clicks to the scrollbar underneath willwork. Child elements of the navbar that need to receive clicks have
pointer-events: all;turned on for them.fix vueuse/vueuse#2086
Before
The red highlighted part of the scrollbar could not be clicked and dragged:
After
The part of the scrollbar above can now be clicked and dragged, and all of the other parts of the sidebar and navbar remain clickable as before.