Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lines are ignored in markdown code snippets in 1.0.0-alpha.5 #1175

Closed
3 tasks done
kasvith opened this issue Aug 16, 2022 · 3 comments · Fixed by #1170
Closed
3 tasks done

New lines are ignored in markdown code snippets in 1.0.0-alpha.5 #1175

kasvith opened this issue Aug 16, 2022 · 3 comments · Fixed by #1170
Labels
bug Something isn't working theme Related to the theme

Comments

@kasvith
Copy link

kasvith commented Aug 16, 2022

Describe the bug

In Makrdown code snippets new lines are now being ignored. You need to manually add <space> with a newline to render it in the docs

Reproduction

Create a code snippet which has new lines

Expected behavior

Should render new lines without additional steps

System Info

  System:
    OS: Windows 10 10.0.19044
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz 
    Memory: 6.91 GB / 15.96 GB
  Binaries:
    Node: 16.13.0 - C:\Program Files\nodejs\node.EXE       
    Yarn: 1.22.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 8.1.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 104.0.5112.81
    Edge: Spartan (44.19041.1266.0), Chromium (104.0.1293.54)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    vitepress: ^1.0.0-alpha.5 => 1.0.0-alpha.5

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@kasvith kasvith added the bug: pending triage Maybe a bug, waiting for confirmation label Aug 16, 2022
@brc-dd
Copy link
Member

brc-dd commented Aug 16, 2022

Yeah, #1170 will fix this.

@brc-dd brc-dd added bug Something isn't working theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Aug 16, 2022
@Charles7c
Copy link
Contributor

Yeah, #1170 will fix this.

Can this be fixed as well?
image

@brc-dd
Copy link
Member

brc-dd commented Aug 16, 2022

@Charles7c fixed in #1178

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants