Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ads display #230

Merged
merged 1 commit into from
Feb 10, 2021
Merged

fix: ads display #230

merged 1 commit into from
Feb 10, 2021

Conversation

posva
Copy link
Member

@posva posva commented Feb 10, 2021 •
edited
Loading

In mobile:

  • better spacing around the ad at the top
  • Fix the layout shift due to float

Old:

Screen Shot 2021-02-10 at 09 41 50

Fixed:

Screen Shot 2021-02-10 at 09 43 26

https://deploy-preview-230--vitepress-docs.netlify.app/

kiaking
kiaking approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙌 Now I'm noticing that ads image is squashed a little horizontally but that has nothing to do with this PR, so this fix is just making things better 👍 👍 👍

@kiaking kiaking merged commit 7ceaf34 into master Feb 10, 2021
@kiaking kiaking deleted the fix/ad-fix branch February 10, 2021 09:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kiaking kiaking kiaking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@posva @kiaking