-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip external URLs in withBase
#328
Conversation
Maybe is worth for withBase to skip paths that start with BTW, in a regex you can write |
Yeah I also think |
OK, sir |
I will make changes according to your suggestions. :) |
02ecd56
to
b2d4570
Compare
@kiaking I think we should move the RE in a shared file. I saw multiple occurrences of it across the codebase |
b2d4570
to
16a241d
Compare
16a241d
to
2842c36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
withBase
Reason
I found that
withBase
will add path for all path, if I want to use some web resource. It's no need. So I add some path check for some urlMore
I have no idea for that there is necessary to check all
path
which is been wrappedwithBase
.