feat: improve typescript support for config file #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulivz
force-pushed
the
feat/config-type
branch
from
e985b58
to
9d5d366
Compare
ulivz
commented
Dec 11, 2021
| export * from '../dist/node/index' | ||
| export * from '../dist/client/index' | ||
| export * from '../dist/client/theme-default/config' |
There was a problem hiding this comment.
Remove this export since it does not exists: https://unpkg.com/browse/[email protected]/dist/client/
ulivz
commented
Dec 11, 2021
| @@ -1,146 +1 @@ | |||
| export namespace DefaultTheme { | |||
There was a problem hiding this comment.
Move this file to shared types since we need it between server and client.
ulivz
force-pushed
the
feat/config-type
branch
from
9d5d366
to
712e8af
Compare
ulivz
commented
Dec 11, 2021
src/node/config.ts
Outdated
| export function defineConfig(config: RawConfigExports) { | ||
| export function defineConfig<T extends ThemeConfig = ThemeConfig>( | ||
| config: UserConfig<T>, | ||
| usingCustomTheme: true |
There was a problem hiding this comment.
Motivation here: TypeScript cannot overload a function type inferring based on the number of generic type parameters, so I added an additional function parameters here.
|
@yyx990803 Could you help review this pull request? |
3 tasks
|
An extra argument to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #464