fix: dont' minimize non-javascript inline scripts #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can't add a script tag to the head which has content that is not valid JavaScript code (JSON for example).
This won't work:
```html
module.exports = {
head: [
['script', { type: 'application/ld+json', '{ "foo": "bar" }']
]
}
```
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e61db62 introduced the minification of inline JavaScript.
Unfortunately this feature tries to minify the content of any
<script>tag that is inserted into the<head>.A
<script>tag can contain not only JavaScript, but also JSON for example.Therefore this won't work:
A detailed bug report can be found here: #538