Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When modifying config.ts imported outside of .vitepress folder, it is not hot reload #581

Closed
3 tasks done
lovetingyuan opened this issue Mar 17, 2022 · 0 comments · Fixed by #1009
Closed
3 tasks done
Labels
build Related to the build system enhancement New feature or request

Comments

@lovetingyuan
Copy link

Describe the bug

image

I use the config file out of .vitepress, I just import it in .vitepress/config.ts

when I modify .vitepress/config.ts, hot reload works well, but I modify the outer config.ts, hot reloading does not work.

Reproduction

Just modify the outer config.ts, the page does not get update.

Expected behavior

I think vitepress should track the import modules graph in .vitepress/config.ts, and hot reload all of them.

System Info

System:
    OS: macOS 12.0.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 668.14 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.1 - ~/.volta/tools/image/node/16.14.1/bin/node
    Yarn: 1.22.15 - ~/.yarn/bin/yarn
    npm: 7.10.0 - ~/.volta/tools/image/npm/7.10.0/bin/npm
  Browsers:
    Chrome: 99.0.4844.74
    Edge: 98.0.1108.55
    Firefox: 95.0.2
    Safari: 15.1

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@lovetingyuan lovetingyuan added the bug: pending triage Maybe a bug, waiting for confirmation label Mar 17, 2022
@kiaking kiaking added enhancement New feature or request build Related to the build system and removed bug: pending triage Maybe a bug, waiting for confirmation labels May 23, 2022
@kiaking kiaking changed the title When I modify config.ts, it is not hot reload. When modifying config.ts imported outside of .vitepress folder, it is not hot reload May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Related to the build system enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants