Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emit 404.html on build (#729) #740

Merged
merged 4 commits into from
Jun 14, 2022
Merged

feat: emit 404.html on build (#729) #740

merged 4 commits into from
Jun 14, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jun 7, 2022 •
edited
Loading

fixes: #729

  • Works with MPA mode.
  • Works with custom 404 page.
  • Works with custom NotFound component.
  • No extra config required for Netlify, Vercel, GitHub Pages, ....

@brc-dd brc-dd marked this pull request as draft June 7, 2022 14:49
@brc-dd brc-dd marked this pull request as ready for review June 7, 2022 14:59
kiaking
kiaking approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! Wonderful work!!! 🎉 🎉 🎉

@kiaking kiaking changed the title feat: emit 404.html to dist feat: emit 404.html to dist (#729) Jun 14, 2022
@kiaking kiaking changed the title feat: emit 404.html to dist (#729) feat: emit 404.html on build (#729) Jun 14, 2022
@kiaking kiaking merged commit 23276ba into main Jun 14, 2022
@kiaking kiaking deleted the feat/emit-404 branch June 14, 2022 08:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kiaking kiaking kiaking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate 404.html on build
2 participants
@brc-dd @kiaking