Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): show close icon when nav menu is open #744

Merged
merged 4 commits into from
Jun 21, 2022
Merged

fix(theme): show close icon when nav menu is open #744

merged 4 commits into from
Jun 21, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jun 7, 2022

No description provided.

@brc-dd
Copy link
Member Author

brc-dd commented Jun 11, 2022

This also fixes an issue when hovering anywhere on the navbar was triggering the menu icon to change.

@brc-dd
Copy link
Member Author

brc-dd commented Jun 11, 2022 •
edited
Loading

And, also fixes the one where hovering over button (outside the icon container) was not causing the icon to change.

@brc-dd brc-dd changed the title fix(styles): show close icon when nav menu is open fix(theme): show close icon when nav menu is open Jun 17, 2022
@brc-dd brc-dd requested a review from kiaking June 17, 2022 07:47
@kiaking kiaking merged commit 75c9d80 into main Jun 21, 2022
@kiaking kiaking deleted the chore/cleanup branch June 21, 2022 10:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kiaking kiaking kiaking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brc-dd @kiaking