Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add italic fonts #777

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix: add italic fonts #777

merged 1 commit into from
Jun 16, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jun 11, 2022

fixes: #759

@kecrily
Copy link
Contributor

kecrily commented Jun 11, 2022

Is it really necessary to have italic font built in? Why not fallback to other fonts.

@brc-dd
Copy link
Member Author

brc-dd commented Jun 11, 2022

@kecrily Falling back doesn't appear to be working here. We had "Inter, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen, Ubuntu, Cantarell, "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif" as font family. Setting font-style: italic on an element was not using any fallback font and the text was rendering with normal font style.

@HipyCas
Copy link

HipyCas commented Jun 12, 2022

When will this be merged???

@kiaking kiaking merged commit fa00c83 into main Jun 16, 2022
@kiaking kiaking deleted the fix/fonts branch June 16, 2022 13:06
brc-dd added a commit that referenced this pull request Jun 17, 2022
* refactor: refine global layout system

* chore: remove unknown console log from release script

* release: v1.0.0-alpha.2

* docs: add Layer0 deployment notes

Co-authored-by: meteorlxy <[email protected]>

* docs: add cloudflare pages deploy (#797)

close #369 

Co-authored-by: Kia King Ishii <[email protected]>

* refactor: improve site data parsing (#780)

* fix: copy code in non-secure contexts (#792)

Co-authored-by: Divyansh Singh <[email protected]>

* fix(theme): add italic fonts (#759) (#777)

fix #759

* docs: image migration guide for vuepress (#799)

* refactor(types): use built-in utility type `Awaited` (#801)

instead of explicitly defining it. (introduced in TS 4.5)

* feat(theme): support themeable images for logo and hero (#745)

Co-authored-by: Divyansh Singh <[email protected]>

Co-authored-by: Kia King Ishii <[email protected]>
Co-authored-by: Rishi Raj Jain <[email protected]>
Co-authored-by: meteorlxy <[email protected]>
Co-authored-by: Percy Ma <[email protected]>
Co-authored-by: Linmj <[email protected]>
Co-authored-by: JD Solanki <[email protected]>
Co-authored-by: CHOYSEN <[email protected]>
Co-authored-by: Anthony Fu <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper italic/cursive rendering
4 participants