Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): make last updated time reactive #879

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

RainKolwa
Copy link
Contributor

The last updated time should be a computed value based on page-data.

This PR fixes:

When you go through pages on VitePress Docs, last updated time stays the same.The time we saw on each page used the updated time of the first landed page, then it never changes.
But if you refresh on a specific page, you can see the right last updated time.

@brc-dd brc-dd changed the title fix: last updated time fix(theme): make last updated time reactive Jun 29, 2022
@brc-dd brc-dd merged commit 25a835f into vuejs:main Jun 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants