Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue3): inject value showing default over falsy value #1976

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix(vue3): inject value showing default over falsy value #1976

merged 1 commit into from
Jan 20, 2023

Conversation

psevertson
Copy link
Contributor

Description

The Injects values are incorrectly coalescing falsy values to their default values when the component is written in Options mode.

Additional context

If a parent component provides a falsy value (false, null, 0, "", etc.), then a child component written in Options mode will incorrectly coalese that and show the default value given for the inject.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@Akryum Akryum changed the title Fixes inject value showing default over falsy value fix(vue3): inject value showing default over falsy value Jan 20, 2023
@Akryum Akryum merged commit 0c06c01 into vuejs:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants