Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: Simulate Vue 2.6.14 version in vue-compat #5293

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

CyberAP
Copy link
Contributor

@CyberAP CyberAP commented Jan 20, 2022

Some Vue plugins that are actually compatible with the vue-compat won't work because of the version check (an example from vue apollo). Right now vue-compat returns 3x version for the legacy method of checking Vue version via Vue.version. This PR instends to simulate Vue 2 version in those instances and instead return a 2x-compatible version: 2.6.14-compat:3.x.x.

Some Vue plugins that are actually compatible with the `vue-compat` won't work because of the version check. Right now `vue-compat` returns 3x version for the legacy method of checking Vue version via `Vue.version`. This PR instends to simulate Vue 2 version in those instances and instead return a 2x-compatible version: `2.6.14-compat:3.x.x`.
@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 0c9cc89

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/61e901cde7e62700074d0645

😎 Browse the preview: https://deploy-preview-5293--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 0c9cc89

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/61e901cd256da20008c16f4f

😎 Browse the preview: https://deploy-preview-5293--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 0c9cc89

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/61e901cd79ea080007108ba8

😎 Browse the preview: https://deploy-preview-5293--vue-sfc-playground.netlify.app/

@yyx990803 yyx990803 merged commit d0b9708 into vuejs:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants