-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cssVars): work with calc complex expression #5306
Conversation
✔️ Deploy Preview for vuejs-coverage ready! 🔨 Explore the source changes: 998cf37 🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/61ed1968c15dcf00074fbcef 😎 Browse the preview: https://deploy-preview-5306--vuejs-coverage.netlify.app |
✔️ Deploy Preview for vue-next-template-explorer ready! 🔨 Explore the source changes: 998cf37 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/61ed1968523ce60007332bb8 😎 Browse the preview: https://deploy-preview-5306--vue-next-template-explorer.netlify.app |
✔️ Deploy Preview for vue-sfc-playground ready! 🔨 Explore the source changes: 998cf37 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/61ed19689307b30007777134 😎 Browse the preview: https://deploy-preview-5306--vue-sfc-playground.netlify.app/ |
@@ -13,7 +13,7 @@ import hash from 'hash-sum' | |||
|
|||
export const CSS_VARS_HELPER = `useCssVars` | |||
export const cssVarRE = | |||
/\bv-bind\s*\(\s*(?:'([^']+)'|"([^"]+)"|([^'"][^;]*))\s*\)/g | |||
/\bv-bind\s*\(\s*(?:'([^']+)'|"([^"]+)"|([^'"]|[\w]*|[^;]*))\s*\)/g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would fail on calc(v-bind(foo + 123))
close #5302