fix(v-on): avoid events with empty keyCode (autocomplete) #11326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)Other information:
Chromium browsers (and Safari) trigger a
keydown
/keyup
event on autocomplete. AnEvent
object withoutkey
orkeyCode
is generated.Vue, when listening with modifiers, is triggering the callback even if the modifier key doesn't match the
undefined
keyCode of the event.Current behaviour: https://codepen.io/zupolgec/pen/RwWRxdK
New behaviour: https://codepen.io/zupolgec/pen/qBONxMj
Try autocompleting the first field: in the first demo is counted, in the second demo is ignored.
See also same kind of issue on another JS library: alpinejs/alpine#389 (comment)