Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: spelling and grammar. fix #11480 #11481

Merged
merged 1 commit into from
Jul 1, 2020
Merged

chore: spelling and grammar. fix #11480 #11481

merged 1 commit into from
Jul 1, 2020

Conversation

warmsocks
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Spelling and grammar

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This is a drive-by contribution, and I had trouble testing on my host. When I ran npm test, everything succeeded/passed until attempting to start a webserver, since I already have something listening on port 8080 that I didn't want to shut down. I tried _npm test --port 8111, which looked like it was going to work, but there are a bunch of hard-coded instances of :8080 under e2e/specs that I think are the cause. I'll open a separate issue for that.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Since this change is only related to comments, you don't even need to run the test suit 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants