Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sync modifier with bind object #5943

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Conversation

Kingwl
Copy link
Member

@Kingwl Kingwl commented Jun 21, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
#5937

@Kingwl Kingwl requested a review from yyx990803 June 21, 2017 13:18
} else {
// bind update event for sync modifier and bind object
if (modifiers && modifiers.sync && name === 'v-bind') {
addSyncUpdateHandler(el, value, value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a bit more complicated than that as we need to add a handler for every property in the v-bind object but I haven't researched much.

Also, imagine the case where value is directly an object: { foo, bar }, we really want to add update:foo and update:bar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed😃

@Kingwl Kingwl changed the title add sync modifier with bind object (#5937) add sync modifier with bind object Jun 22, 2017
@yyx990803 yyx990803 merged commit 3965e50 into vuejs:dev Jun 30, 2017
@Kingwl Kingwl deleted the dev-sync-bind-object branch June 30, 2017 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants