-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #9046 disable dep collection when invoking lifecycle hooks will be useless when invoking computed in lifecycle #9095
Conversation
In lifecycle.js lines316 , the method 'callHook', disable dep collection when invoking lifecycle hooks by 'pushTarget()', which means the dep collection will be useless in the lifecycle method. The principle of this is that when pushTarget(), the params--watcher is 'undefined', so in the lifecycle method--mounted, Dep.target is 'undefined', which means will not run dep collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be !=
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test that was failing before adding this check?
@jacekkarczmarczyk distinguish undefined from null, Dep.target would be undefined in lifecycle.js line316 |
@posva I've pushed a test |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: