fix: missing edit links under non-contentLoading situations

vuejs · Nov 6, 2018 · 47e9654 · 47e9654
1 parent f39f79b
commit 47e9654
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 11 deletions.
diff --git a/packages/@vuepress/core/lib/app/components/Content.vue b/packages/@vuepress/core/lib/app/components/Content.vue
@@ -35,7 +35,7 @@ export default {
   },
 
   computed: {
-    $key () {
+    $pageKey () {
       return this.pageKey || this.$page.key
     },
     disableTransition () {
@@ -44,14 +44,11 @@ export default {
   },
 
   created () {
-    this.loadContent(this.$key)
-    this.$vuepress.$on('AsyncMarkdownContentMounted', (slotKey) => {
-      this.$vuepress.$set('contentMounted', true)
-    })
+    this.loadContent(this.$pageKey)
   },
 
   watch: {
-    $key (key) {
+    $pageKey (key) {
       this.$vuepress.$set('contentMounted', false)
       this.reloadContent(key)
     }

diff --git a/packages/@vuepress/core/lib/app/plugins/VuePress.js b/packages/@vuepress/core/lib/app/plugins/VuePress.js
@@ -29,8 +29,8 @@ class VuePress extends Store {
 
 export default {
   install (Vue) {
-    const store = new VuePress()
-    Vue.$vuepress = store
-    Vue.prototype.$vuepress = store
+    const ins = new VuePress()
+    Vue.$vuepress = ins
+    Vue.prototype.$vuepress = ins
   }
 }
diff --git a/packages/@vuepress/core/lib/app/root-mixins/updateLoadingState.js b/packages/@vuepress/core/lib/app/root-mixins/updateLoadingState.js
@@ -0,0 +1,13 @@
+export default {
+  created () {
+    this.$vuepress.$on('AsyncMarkdownContentMounted', () => {
+      this.$vuepress.$set('contentMounted', true)
+    })
+  },
+
+  watch: {
+    $page () {
+      this.$vuepress.$set('contentMounted', false)
+    }
+  }
+}
diff --git a/packages/@vuepress/core/lib/internal-plugins/rootMixins.js b/packages/@vuepress/core/lib/internal-plugins/rootMixins.js
@@ -7,7 +7,8 @@ module.exports = (options, context, api) => ({
   // @internal/root-mixins
   async clientDynamicModules () {
     const builtInRootMixins = [
-      path.resolve(__dirname, '../app/root-mixins/updateMeta.js')
+      path.resolve(__dirname, '../app/root-mixins/updateMeta.js'),
+      path.resolve(__dirname, '../app/root-mixins/updateLoadingState.js')
     ]
 
     const rootMixins = [

diff --git a/packages/@vuepress/plugin-active-header-links/mixin.js b/packages/@vuepress/plugin-active-header-links/mixin.js
@@ -44,7 +44,6 @@ function getAnchors () {
 export default {
   mounted () {
     this.$vuepress.$on('AsyncMarkdownContentMounted', (slotKey) => {
-      console.warn('AsyncMarkdownContentMounted')
       if (slotKey === 'default') {
         window.addEventListener('scroll', this.onScroll)
       }