Markdown line highlighting fails in v1.0.0-alpha.40

[AngusFu]

• I confirm that this is a issue rather than a question.

Bug report

It seems that v1.0.0-alpha.40 breaks markdown line highlighting feature.

I believe this is caused by commit f04adbf1, which changed @vuepress/markdown-loader/index.js. Since I replaced the content of node_modules/@vuepress/markdown-loader/index.js with code from previous version, everything turns normal.

Version

v1.0.0-alpha.40

Steps to reproduce

I created a simple repo: vuepress-bug-report

What is expected?

markdown line highlighting feature should works.

What is actually happening?

Other relevant information

None

[AngusFu]

@shigma Two way to fix this issue (basically by reverting some changes):

• remove md.parse = (src, env) => {
• or, recover the LRU instance cache in markdown-loader

I have no idea why the whole compiling runs twice, with the requests being:

request:"${HOME}/vuepress-bug-report/node_modules/cache-loader/dist/cjs.js??ref--1-0!${HOME}/vuepress-bug-report/node_modules/vue-loader/lib/index.js??ref--1-1!${HOME}/vuepress-bug-report/node_modules/@vuepress/markdown-loader/index.js??ref--1-2!${HOME}/vuepress-bug-report/docs/README.md"

request:"${HOME}/vuepress-bug-report/node_modules/cache-loader/dist/cjs.js?{"cacheDirectory":"node_modules/@vuepress/core/node_modules/.cache/vuepress","cacheIdentifier":"0954d92e-vue-loader-template"}!${HOME}/vuepress-bug-report/node_modules/vue-loader/lib/loaders/templateLoader.js??vue-loader-options!${HOME}/vuepress-bug-report/node_modules/cache-loader/dist/cjs.js??ref--1-0!${HOME}/vuepress-bug-report/node_modules/vue-loader/lib/index.js??ref--1-1!${HOME}/vuepress-bug-report/node_modules/@vuepress/markdown-loader/index.js??ref--1-2!${HOME}/vuepress-bug-report/docs/README.md?vue&type=template&id=c6f5370e&"

By rewriting md.parse, of course we can cache tokens, BUT highlightLines.js would rewrite (link) token.info during the first compilation. Thus, when it comes to the second compilation process, it outputs the wrong result. (I don't know why we got two 😭 )

    const langName = rawInfo.replace(RE, '').trim()
    // ensure the next plugin get the correct lang.
    token.info = langName

[shigma]

@AngusFu Thanks a lot!

To address this issue, I found a simple solution here.

However, I believe recover the LRU instance cache is much safer for more potential problems. You are right. Accually, we have met such things before.

cc @ulivz

[meteorlxy]

And the markdown toc fails for the similar reason

[shigma]

@meteorlxy Fixed at #1375