Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugin container #1381

Merged
merged 5 commits into from
Mar 2, 2019
Merged

feat: plugin container #1381

merged 5 commits into from
Mar 2, 2019

Conversation

shigma
Copy link
Collaborator

@shigma shigma commented Mar 1, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

  • Introduced a brand new multiple plugin: vuepress-plugin-container. Since custom containers are quite common in websites, it will help a lot if users have easy access to a container plugin.
  • improved code reusability in VuePress.
  • Updated related docs.

@shigma shigma changed the title [WIP] feat: plugin container feat: plugin container Mar 1, 2019
@shigma shigma requested a review from ulivz March 1, 2019 14:45
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but maybe we need to move "markdown-it-container" to container plugin.

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulivz ulivz merged commit ad0ff72 into master Mar 2, 2019
@shigma shigma deleted the plugin-container branch March 2, 2019 15:51
@tedmiston
Copy link
Contributor

@shigma @ulivz Thank you for creating this plugin. It seems there is a bug in vuepress v1.0.0-alpha.41 breaking on the markdown-it-container dependency not being present. This is resolved by installing the missing dependency. I have created a bug report issue #1387 but wanted to cross-link here for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants