Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Theme - External Link Regex: Allow for System Deep Links #1677

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

DBULL7
Copy link
Contributor

@DBULL7 DBULL7 commented Jun 26, 2019

Summary

Allow users to have links that open system applications (i.e. deep links).

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe: Regex condition

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

My company is using Vuepress for an internal documentation site. We would like to be able to use deep links to open our bug tracking app so other internal teams can help improve our documentation (most employee's won't have access to the enterprise Github and the repo is restricted). The current default-theme external link regex doesn't take into account these types of links for navbar links or for editLinks with our deep link in place of a normal docRepo link in themeConfig and fails to open them correctly (unless done manually with in markdown <a> tags inside the pages themselves). I found the Apple documentation here that best describes what we're trying to do. If you have any questions please reach out and hopefully I can answer them!

We're huge fans of what y'all do! Thank you for your time and consideration 👋

@ulivz
Copy link
Member

ulivz commented Jul 1, 2019

Cool! Thanks for your support for VuePress!

@ulivz ulivz merged commit 27f005b into vuejs:master Jul 1, 2019
@vue-bot
Copy link

vue-bot commented Jul 1, 2019

Thanks again! 💚

@xr0master
Copy link
Contributor

Only one question guys, why 4? sms, ftp and etc... going to fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants