Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($shared-utils): remove leading slash of regularPath when getting permalink #1786

Merged
merged 1 commit into from
Sep 22, 2019

Conversation

billyyyyy3320
Copy link
Collaborator

Summary

relevant to #1783

:regular is different with all the other template variables(only :regular can't go before a slash).

Besides, I found VuePress can't work fine if someone config like below(although It‘s a meaningless config), and this PR will also solve this problem:

module.exports = {
  permalink: ":regular"
};

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@billyyyyy3320 billyyyyy3320 changed the title feat($shared-utils): remove leading slash of regularPath when getting… feat($shared-utils): remove leading slash of regularPath when getting permalink Aug 18, 2019
@ulivz ulivz merged commit c6ce6cf into master Sep 22, 2019
@vue-bot
Copy link

vue-bot commented Sep 22, 2019

Hey @newsbielt703, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants