Make mutation and action payload optional in definition file #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing a mutation without payload in TypeScript, it complains that about the missing payload, even though it's not mandatory. This PR simply makes the payload optional. Fixes vuejs#1491
ktsn
requested changes
Mar 7, 2019
davidsandoz
changed the title
|
@ktsn, change for action payload is now done as well. |
This was referenced Aug 29, 2019
This was referenced Nov 18, 2019
This was referenced Jan 21, 2020
This was referenced Mar 1, 2020
vaga
pushed a commit
to vaga/vuex
that referenced
this pull request
Apr 20, 2020
…ile (vuejs#1517) * Make mutation payload optional in definition file When testing a mutation without payload in TypeScript, it complains that about the missing payload, even though it's not mandatory. This PR simply makes the payload optional. Fixes vuejs#1491 * Make action payload optional in definition file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing a mutation without payload in TypeScript, it complains that about the missing payload, even though it's not mandatory.
This PR simply makes the payload optional.
Fixes #1491