-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow action subscribers to catch rejections. #1740
Conversation
…or rejections without a throw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! It's looking good to me. But, there's still dist
folder in the commit 😓 Could you please remove it 🙏
Sorry @jmplahitko, I don't think we've been very clear in what we're asking of you, and I apologise for that. When members ask to have If it makes things easier, 1) take the Hope that makes a little more sense. |
@kiaking - Not your fault, I misunderstood. Hopefully that last commit gets us there. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks so much for the work. We know we need to fix the test because we've just switched to using Jest, but I'll fix that right after merging this one 👍
@kiaking - Thanks for the direction. This is the pull request to replace #1531