Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typscript compile error - logger.d.ts missing in NPM package #1787

Closed
bcronje opened this issue Jun 29, 2020 · 2 comments · Fixed by #1789
Closed

Typscript compile error - logger.d.ts missing in NPM package #1787

bcronje opened this issue Jun 29, 2020 · 2 comments · Fixed by #1789
Assignees
Labels
bug Something isn't working types Related to typings only

Comments

@bcronje
Copy link

bcronje commented Jun 29, 2020

Version

3.5.0

Reproduction link

https://jsfiddle.net/chrisvfritz/50wL7mdz/

Steps to reproduce

Create default typescript project:

vue create test

? Please pick a preset: Manually select features
? Check the features needed for your project: Babel, TS, Router, Vuex, Linter
? Use class-style component syntax? No
? Use Babel alongside TypeScript (required for modern mode, auto-detected polyfills, transpiling JSX)? Yes
? Use history mode for router? (Requires proper server setup for index fallback in production) No
? Pick a linter / formatter config: Prettier
? Pick additional lint features: Lint on save
? Where do you prefer placing config for Babel, ESLint, etc.? In dedicated config files

cd test
npm run serve

What is expected?

Expects to compile without errors.

What is actually happening?

ERROR in D:/test/node_modules/vuex/types/index.d.ts(7,26):
7:26 Cannot find module './logger' or its corresponding type declarations.
5 |
6 | import { mapState, mapMutations, mapGetters, mapActions, createNamespacedHelpers } from "./helpers";

7 | import createLogger from "./logger";
| ^
8 |
9 | export * from "./helpers";
10 | export * from "./logger";
ERROR in D:/test/node_modules/vuex/types/index.d.ts(10,15):
10:15 Cannot find module './logger' or its corresponding type declarations.
8 |
9 | export * from "./helpers";
10 | export * from "./logger";


logger.d.ts file is missing in types folder when installed via npm.

@bcronje
Copy link
Author

bcronje commented Jun 29, 2020

Sorry I don't know how to create a repo in JSFiddle for TS project. Basically logger.d.ts is missing in the 3.5.0 npm package resulting in TS compile error.

image

@kiaking
Copy link
Member

kiaking commented Jun 29, 2020

Thanks for the report! I've confirmed it. Will make a fix in a moment!

@kiaking kiaking added bug Something isn't working types Related to typings only labels Jun 29, 2020
@kiaking kiaking self-assigned this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types Related to typings only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants