feat: add :line-numbers=number supports
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9280691180Details
💛 - Coveralls |
Mister-Hope
reviewed
May 28, 2024
|
can we split these 2 changes? |
I moved the attribute migration to another PR. |
Mister-Hope
requested changes
May 28, 2024
| @@ -229,7 +229,6 @@ div[class*='language-'] { | |||
| padding-top: 1.3rem; | |||
| font-size: 0.875em; | |||
| line-height: $line-height; | |||
| counter-reset: line-number; | |||
There was a problem hiding this comment.
Do not remove, currently using counter-increment for line numbering.
There was a problem hiding this comment.
I think its ok for you to use actual numbers like vitepress.
By this, the line number is coupled with an outside style.
But if we want the style built-in, then I think this should be fine.
There was a problem hiding this comment.
When writing numbers into the DOM, plugin-seo includes the numbers from line-numbers in the og:description, but it does not include the code blocks content, which seems a bit strange. Perhaps plugin-seo needs to make some adjustments.
Mister-Hope
requested changes
May 29, 2024
Mister-Hope
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123).What is the purpose of this pull request?
Description