Skip to content

Commit

Permalink
Breaking: drop node < 10 and upgrade dependencies
Browse files Browse the repository at this point in the history
Now silently exits on node < 10. Two dozen remark modules have
been upgraded, many with breaking changes though most don't apply
here. One thing I've noticed is that text like "[email protected]" will
be converted to a mailto link. Wrap such text in backticks.
  • Loading branch information
vweevers committed Aug 22, 2020
1 parent f4e0d8d commit 02e7c00
Show file tree
Hide file tree
Showing 5 changed files with 44 additions and 41 deletions.
8 changes: 4 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
language: node_js
node_js:
- "6"
- "8"
- "10"
- "12"
- 8
- 10
- 12
- 14
cache:
directories:
- dependents
4 changes: 2 additions & 2 deletions cli.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/usr/bin/env node
'use strict'

if (process.version.match(/^v(\d+)\./)[1] < 8) {
console.error('hallmark: Node 8 or greater is required. `hallmark` did not run.')
if (process.version.match(/^v(\d+)\./)[1] < 10) {
console.error('hallmark: Node 10 or greater is required. `hallmark` did not run.')
process.exit(0)
}

Expand Down
2 changes: 1 addition & 1 deletion options.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ module.exports = function (argv, pkg, packageOpts, files, cwd, repository) {
listItemIndent: '1',

// Allow disabling padding because on big tables it creates noise.
paddedTable: packageOpts.paddedTable,
tablePipeAlign: packageOpts.paddedTable,

// In addition, use fixed width columns.
stringLength: packageOpts.paddedTable ? (s) => String(s).length : () => 3
Expand Down
66 changes: 33 additions & 33 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,47 +11,47 @@
"check-licenses": "npm-consider install --test --production"
},
"dependencies": {
"deglob": "~4.0.0",
"find-root": "~1.1.0",
"markdown-extensions": "~1.1.1",
"remark": "~11.0.0",
"deglob": "^4.0.0",
"find-root": "^1.1.0",
"markdown-extensions": "^1.1.1",
"remark": "^12.0.1",
"remark-changelog": "~0.1.2",
"remark-collapse": "~0.1.2",
"remark-git-contributors": "~2.0.0",
"remark-github": "~8.0.0",
"remark-lint": "~6.0.2",
"remark-lint-blockquote-indentation": "~1.0.2",
"remark-lint-checkbox-character-style": "~1.0.2",
"remark-lint-checkbox-content-indent": "~1.0.2",
"remark-lint-code-block-style": "~1.0.2",
"remark-lint-definition-case": "~1.0.2",
"remark-lint-final-newline": "~1.0.2",
"remark-lint-hard-break-spaces": "~1.0.3",
"remark-lint-list-item-bullet-indent": "~1.0.2",
"remark-lint-list-item-indent": "~1.0.2",
"remark-lint-no-auto-link-without-protocol": "~1.0.2",
"remark-lint-no-blockquote-without-marker": "~2.0.2",
"remark-lint-no-duplicate-definitions": "~1.0.2",
"remark-lint-no-heading-content-indent": "~1.0.2",
"remark-lint-no-inline-padding": "~1.0.2",
"remark-lint-no-literal-urls": "~1.0.2",
"remark-lint-no-undefined-references": "~1.1.0",
"remark-lint-no-unused-definitions": "~1.0.2",
"remark-lint-table-cell-padding": "~1.0.2",
"remark-lint-table-pipes": "~1.0.2",
"remark-toc": "~6.0.0",
"remark-validate-links": "~9.0.1",
"subarg": "~1.0.0",
"supports-color": "~6.1.0",
"unified-engine": "~7.0.0"
"remark-git-contributors": "^3.0.0",
"remark-github": "^9.0.1",
"remark-lint": "^7.0.1",
"remark-lint-blockquote-indentation": "^2.0.1",
"remark-lint-checkbox-character-style": "^2.0.1",
"remark-lint-checkbox-content-indent": "^2.0.1",
"remark-lint-code-block-style": "^2.0.1",
"remark-lint-definition-case": "^2.0.1",
"remark-lint-final-newline": "^1.0.2",
"remark-lint-hard-break-spaces": "^2.0.1",
"remark-lint-list-item-bullet-indent": "^2.0.1",
"remark-lint-list-item-indent": "^2.0.1",
"remark-lint-no-auto-link-without-protocol": "^2.0.1",
"remark-lint-no-blockquote-without-marker": "^3.0.1",
"remark-lint-no-duplicate-definitions": "^2.0.1",
"remark-lint-no-heading-content-indent": "^2.0.1",
"remark-lint-no-inline-padding": "^2.0.1",
"remark-lint-no-literal-urls": "^2.0.1",
"remark-lint-no-undefined-references": "^2.0.1",
"remark-lint-no-unused-definitions": "^2.0.1",
"remark-lint-table-cell-padding": "^2.0.1",
"remark-lint-table-pipes": "^2.0.1",
"remark-toc": "^7.0.0",
"remark-validate-links": "^10.0.2",
"subarg": "^1.0.0",
"supports-color": "^7.1.0",
"unified-engine": "^8.0.0"
},
"devDependencies": {
"git-pull-or-clone": "^1.3.0",
"git-pull-or-clone": "^2.0.1",
"level-community": "^3.0.0",
"npm-consider": "^1.7.0",
"rimraf": "^3.0.0",
"standard": "^14.0.0",
"tape": "^4.10.2",
"tape": "^5.0.1",
"vfile-reporter-json": "^2.0.0"
},
"repository": {
Expand Down
5 changes: 4 additions & 1 deletion test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ const dependents = [
'Level/codec',
'Level/compose',
'Level/level-js',
'Level/levelup',

// TODO: Don't use literal URLs without angle brackets
// 'Level/levelup',

'Level/memdown',
'Level/subleveldown',
'vweevers/detect-tabular',
Expand Down

0 comments on commit 02e7c00

Please sign in to comment.