Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnpmconfig deprecation warning #101

Closed
ralphtheninja opened this issue Sep 16, 2022 · 7 comments
Closed

libnpmconfig deprecation warning #101

ralphtheninja opened this issue Sep 16, 2022 · 7 comments

Comments

@ralphtheninja
Copy link
Collaborator

ralphtheninja commented Sep 16, 2022

I get a deprecation warning for libnpmconfig:

npm WARN deprecated [email protected]: This module is not used anymore. npm config is parsed by npm itself and by @npmcli/config

$ npm ls libnpmconfig
└─┬ [email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └── [email protected]

Not sure what the best way would be to get rid of it. Upgrade to @npmcli/config?

@ralphtheninja ralphtheninja changed the title libnpmconfi deprecation warning libnpmconfig deprecation warning Sep 16, 2022
@vweevers
Copy link
Owner

We should get @npmcli/config if we upgrade unified-engine.

@ralphtheninja
Copy link
Collaborator Author

PR welcome?

@vweevers
Copy link
Owner

Ah we already have a PR: #98. Seems like it's good to merge too, I just forgot about it. If you could verify that it includes the npm module, that'd be great. Nice to see you btw!

@vweevers
Copy link
Owner

Maybe we should merge #100 at the same time as it also depends on unified-engine.

@ralphtheninja
Copy link
Collaborator Author

Maybe we should merge #100 at the same time as it also depends on unified-engine.

Sounds good!

@vweevers
Copy link
Owner

vweevers commented Sep 18, 2022

Having merged both PRs:

$ npm ls libnpmconfig
[email protected]
└── (empty)

I'm making a few unrelated fixes to remark-common-changelog (vweevers/remark-common-changelog@8661c44), will release afterwards.

@vweevers
Copy link
Owner

4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants