Restore previous repo behavior of remark-validate-links #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 9.0.0, remark-validate-links tries to get the repo url from git remotes (which is not desirable for forks) rather than the package.json. Hallmark now reads package.json itself and passes the repo url to remark-validate-links.
vweevers
added a commit
to vweevers/node-docker-machine
that referenced
this pull request
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 9.0.0,
remark-validate-linkstries to get the repo url from git remotes (which is not desirable for forks) rather than thepackage.json. Hallmark now readspackage.jsonitself and passes the repo url toremark-validate-links.I also inlined some code for finding & reading the
package.jsonso that this doesn't have to be done 3 times over (bypkg-config,degloband for getting the repo url).