Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding Storage Allocator Does Not Handle Stateful Modules #3989

Closed
cyberthirst opened this issue May 2, 2024 · 1 comment
Closed

Overriding Storage Allocator Does Not Handle Stateful Modules #3989

cyberthirst opened this issue May 2, 2024 · 1 comment

Comments

@cyberthirst
Copy link
Collaborator

Version Information

  • vyper Version (output of vyper --version): commit 4b4e188

Issue description

OverridingStorageAllocator.set_storage_slots_with_overrides() does not
handle stateful module imports and initialization properly and will not
allocate storage and transient storage slots for variables or reentrant
functions defined in a sub-module. The issue is only caught at the code
generation stage and would most likely result in the compiler panicking.

credits: @trocher

@charles-cooper
Copy link
Member

should be fixed in #3789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants