make_setter is incorrect for complex types when RHS references LHS with .append()

[trocher]

Version Information

• vyper Version (output of vyper --version): 0.4.0rc6+commit.608feda9
• OS: osx
• Python Version (output of python --version): 3.11.4

What's your issue about?

Yet another occurrence of #2418 and #3503

Previous fixes patch the occurrence of make_setter in Stmt.parse_Assign(), however the occurrence of make_setter in core.append_dyn_array() called by Expr.parse_Call() happens to be affected by the same issue:

vyper/vyper/codegen/core.py

Line 406 in ad9c10b

make_setter(get_element_ptr(darray_node, len_, array_bounds_check=False), elem_node)

POC

a: DynArray[DynArray[uint256, 10], 10]

@external
def foo() -> DynArray[uint256, 10]:
   self.a.append([1, 2, self.boo(), 4])
   return self.a[0] # returns [11, 12, 3, 4]
@internal
def boo() -> uint256:
   self.a.append([11, 12, 13, 14, 15, 16])
   self.a.pop()
   # it should now be impossible to read any of [11, 12, 13, 14, 15, 16]
   return 3