Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on expected interface method implemented as internal. #4169

Closed
AlbertoCentonze opened this issue Jul 2, 2024 · 1 comment · Fixed by #4178
Closed

Panic on expected interface method implemented as internal. #4169

AlbertoCentonze opened this issue Jul 2, 2024 · 1 comment · Fixed by #4178
Labels
bug - type 0 compiler halts or panics instead of generating code bug - typechecker issue with typechecker bug - UX a bug related to UX
Milestone

Comments

@AlbertoCentonze
Copy link
Contributor

Version Information

  • vyper Version: 0.4.1+commit.f92ef414a

What's your issue about?

Given an interface file foo.vyi

@external
def bar():
    ...

if the interface is imported and implemented in a module:

import foo

implements: foo


# !!!! here we don't add the external modifier
def bar():
    pass

Not using the external modifier makes the compiler panic.

@charles-cooper charles-cooper added Type checker bug - UX a bug related to UX bug - type 0 compiler halts or panics instead of generating code labels Jul 2, 2024
@charles-cooper
Copy link
Member

we should really not require any visibility modifier in .vyi files (everything is external)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug - type 0 compiler halts or panics instead of generating code bug - typechecker issue with typechecker bug - UX a bug related to UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants