feat/Adjust the searchbar to perform searches by title, description or context #238
Conversation
|
@Hardsys-Andre is attempting to deploy a commit to the WEB3DEV Team on Vercel. A member of the Team first needs to authorize it. |
…irection of the link to download Java
pages/tasks/index.js
Outdated
| <SearchBar | ||
| searchQuery={searchQuery} | ||
| setSearchQuery={setSearchQuery} | ||
| placeholder="Search by title, description, or context depth" |
There was a problem hiding this comment.
@Guboehm , done the translation of this item below
components/Filter/utils.js
Outdated
| return issues.filter((issue) => | ||
| Object.entries(selectedFilters).every( | ||
| ([filterName, selectedValue]) => | ||
| !selectedValue || | ||
| issue.fields.some((field) => field.field === filterName && field.value === selectedValue) | ||
| ) && |
There was a problem hiding this comment.
this const has a lot of responsibility, can you separate the responsibilities into more consts?
There was a problem hiding this comment.
@Guboehm and @nomadbitcoin, I made an adjustment to this component because before the search was working but the filter had an error and was not filtering. Despite using the same "const", I separated the two functions into issuesFilter and issuesSearch. I chose this way because the search also has to work within an already established filter.
| @@ -121,7 +125,7 @@ const TaskPage = ({ issues }) => { | |||
| </div> | |||
| <div className="flex flex-col gap-4"> | |||
| {filteredIssues.map((issue) => ( | |||
| <IssueCard key={issue.github_id} issue={issue} t={t} userInfo={userAuth} /> | |||
| <IssueCard key={issue.github_id} issue={issue} userInfo={userAuth} /> | |||
There was a problem hiding this comment.
pass userAuth as parameter is very weird, avoid doing that since we can get this information globally
| @@ -98,10 +98,10 @@ Deploy this project on Vercel in one click: | |||
|
|
|||
| #### Windows | |||
|
|
|||
| 1. Download and install Java from the official [Oracle website](https://www.java.com/en/download/ie_manual.jsp). Make sure to choose the version suitable for your system. | |||
| 1. Download and install SDK Java 20 from the official [Oracle website](https://www.oracle.com/java/technologies/javase/jdk20-archive-downloads.html). Make sure to choose the version suitable for your system. | |||
yarn.lock
Outdated
There was a problem hiding this comment.
Please do not upload changes in these temporary files
There was a problem hiding this comment.
I think search and filtering should be separate hooks that operate on the same data.
nomadbitcoin
merged commit 1fafa5a
into
w3b3d3v:feat/web3task-staging
Brief Information
The type of this pull request is:
What does this PR do?
search the issue card for the desired information within the title, description or context fields
Closes #216